-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: rewritten the image building action #1153
Conversation
One more note - once the image is published in the GHCR, it is set to private by default. You will need to make it public here: https://github.com/orgs/sozu-proxy/packages/container/sozu/settings (dead link until publication) |
Signed-off-by: Mateusz Urbanek <[email protected]>
a4116b4
to
201e487
Compare
Signed-off-by: Mateusz Urbanek <[email protected]>
1b99382
to
5616db0
Compare
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
6e06fe0
to
696f867
Compare
One more thing - I added Dependabot config so the dependencies might be updated automatically, but this also needs to be turned on by admins here: |
6278fdd
to
aeea597
Compare
aeea597
to
83169a0
Compare
Drafting, because even if local build works for me, the GH Action is failing, need to debug it further. |
Ok, passed on my repo branch, should be good for review now 🔥 |
Signed-off-by: Mateusz Urbanek <[email protected]>
93c4248
to
d7901cf
Compare
This looks very nice, thank you. I have no clue wether GHCR is better than docker hub for our needs. Thoughts on Github Container Repository vs Docker hub, @FlorentinDUBOIS ? |
I selected it only because you do not need to manage the credentials during the build process, rotate it, etc. It's just easily integrated into the whole flow. |
+1 for this so i can run it on docker 💯 |
Hello, we have another pull request that fix the ci without rewriting it, |
I tried to add some fixes to the CI, so the docker image is built and published (now to GHCR) correctly. This can be easily changed in the future, if GHCR does not meet the expectations.
The action should work as is, as it's mostly copy-pasted from my other project.